Fix query params parsing (#45)

evgeek · Jan 10, 2024 · 693add2 · 693add2
1 parent 80d2953
commit 693add2
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/src/Services/Url.php b/src/Services/Url.php
@@ -42,7 +42,7 @@ public static function parsePathAndParams(string $url): array
         $params = [];
         $paramsString = parse_url($url)['query'] ?? null;
         if ($paramsString) {
-            parse_str($paramsString, $params);
+            $params = self::parseStr($paramsString);
             $pathString = str_replace("?$paramsString", '', $pathString);
         }
 
@@ -79,4 +79,18 @@ private static function prepareQueryParams(array $params): string
 
         return $paramsString === '' ? '' : "?$paramsString";
     }
+
+    /** @return array<int|string, string> */
+    private static function parseStr(string $query): array
+    {
+        $data = preg_replace_callback(
+            '/(?:^|(?<=&))[^=[]+/',
+            static fn ($match) => bin2hex(urldecode($match[0])),
+            $query
+        );
+
+        parse_str($data, $values);
+
+        return array_combine(array_map('hex2bin', array_keys($values)), $values);
+    }
 }
diff --git a/tests/Unit/Services/UrlTest.php b/tests/Unit/Services/UrlTest.php
@@ -131,6 +131,17 @@ public static function urlForParsingDataProvider(): array
                     'filter' => 'aa=bb;cc!=d\;d',
                 ],
             ],
+            [
+                URL::API . '/segment5/segment6?operation.id=a&b = c',
+                [
+                    'segment5',
+                    'segment6',
+                ],
+                [
+                    'operation.id' => 'a',
+                    'b ' => ' c',
+                ],
+            ],
         ];
     }