[Draft] Use dicts to write configs #149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
@rich_config(help_config=...)
.RichHelpConfiguration()
at the top, and each sub-command may have a tiny tweak. That makes sense!Misc. changes:
Type[RichCommand]
, and this typing is covariant, so it cannot ever return a super-type. The should can be safely updated to return that.RichCommand.help_config
. It didn't feel like this made sense back in 1.7, now it feels less like this makes sense, since rich help configs should be resolved in the context level (since they need to inherit from their parents).stacklevel=2
s to the deprecation warnings.