Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in RationalTest.java #2889

Closed
wants to merge 1 commit into from
Closed

Changes in RationalTest.java #2889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions exercises/practice/rational-numbers/src/test/java/RationalTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ public class RationalTest {

// Helper methods

private static final double DOUBLE_EQUALITY_TOLERANCE = 1e-15;
private static final double DOUBLE_EQUALITY_TOLERANCE = 2e-15;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a look around at how other tracks handle this, I'm wondering if we really need that much accuracy. For example, in the Python track, I think it is checked up to 8 places. What do you think about using 1e-8 for the tolerance?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it's alright. I'm gonna change it to 1e-8.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stamatisn do you plan to make this change as @kahgoh suggested?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had some things to do these past days and I really forgot to do it. I will have it ready in a minute


private void assertDoublesEqual(double x, double y) {
assertThat(x).isEqualTo(y, within(DOUBLE_EQUALITY_TOLERANCE));
assertThat(x).isCloseTo(y, within(DOUBLE_EQUALITY_TOLERANCE));
}

// Tests
Expand Down