Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JUnit 5 support #55

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

ErwinOlie
Copy link
Contributor

  • Updated bin/run.sh and examples/template/pom.xml to support JUnit 5.
  • Renamed existing tests under /tests/ to add -junit4 suffix.
  • For each of the JUnit 4 test under /tests/ a JUnit 5 variation is added.

@ErwinOlie ErwinOlie requested a review from a team as a code owner November 2, 2023 16:11
Copy link

github-actions bot commented Nov 2, 2023

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.
You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.
If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Nov 2, 2023
@ErwinOlie
Copy link
Contributor Author

@ErikSchierboom ready for review

@ErikSchierboom ErikSchierboom reopened this Nov 3, 2023
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I love that you kept the existing test cases too as regression tests.

@ErikSchierboom ErikSchierboom merged commit 38e5c58 into exercism:main Nov 3, 2023
3 checks passed
@ErikSchierboom
Copy link
Member

@ErwinOlie is the next step to update the exercises in the kotlin repo to use JUnit 5?

@ErwinOlie
Copy link
Contributor Author

@ErikSchierboom I don't think it's necessary for the performance improvement ideas. We can backwards support jUnit4 with junit5-vintage-api. However I haven't tried this yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants