Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added guard clause for seting readstream position, when not changed. #615

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Added guard clause for seting readstream position, when not changed. #615

merged 1 commit into from
Mar 18, 2024

Conversation

Bajger
Copy link
Contributor

@Bajger Bajger commented Mar 13, 2024

@Bajger
Copy link
Contributor Author

Bajger commented Mar 13, 2024

@ErikSchierboom Thanks for approval!

@glennj
Copy link
Contributor

glennj commented Mar 13, 2024

I think Erik may not see this for a couple of weeks. @iHiD can you please approve?

@Bajger
Copy link
Contributor Author

Bajger commented Mar 18, 2024

@iHiD Thanks for approving!

@Bajger Bajger merged commit ee92563 into exercism:main Mar 18, 2024
3 checks passed
@Bajger Bajger deleted the 614-Fix-TonelParser-to-return-correct-error-when-parsing-empty-file branch March 18, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iHiD iHiD iHiD approved these changes

@glennj glennj glennj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix TonelParser to return correct error when parsing empty file
3 participants
@Bajger @glennj @iHiD