Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
complex-numbers concept docs #3554
complex-numbers concept docs #3554
Changes from all commits
eda3a5a
8165d51
6fe58da
17d8b42
b0a6f94
9e23c2c
498c565
ca8f941
2f568e5
a51f39f
e2fca12
77f574c
c6ec6a6
2e0f35e
d84f687
934d33c
5653132
759bb5b
ef8ab6e
b4b02ab
153c019
72fabca
38d37f8
bf81d3a
c8b8fc1
f8ac3cd
efd391b
1e59be5
67d0653
93b26d8
5b1dcf3
b674997
02867e1
8942925
0dcf403
6e12c30
d773536
7113623
4dfc09d
a2aa792
f648017
86d4093
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add how to declare a complex number literal here in this section. I like the info you list below, but worry that the "break" might have students "losing the thread".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go away and think about this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to address this as part of b674997.
That changes the document quite a bit, so I'll be particularly interested in your comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs talk about using
0j
, which is the default in the constructor if you omit an imaginary part. Why one would do that is a mystery ... but there you have it...and as I think about this, we may want to show both
complex('0+1j')
andcomplex('1+0j')
, just to hammer home that acomplex
type remains complex, even if its imaginary part is set to zero.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this towards the end of the introduction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't mention the complex plane before, and I had already wondered if we should. I resisted the temptation to include a graphic showing the complex plane and unit circle, and magnitude vs phase. Maybe a Wikipedia link?
Too much of this and we'll be discussing the Cauchy-Riemann equations and having to explain partial differential equations...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not sure what to do about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me either. All of the examples I've found have shown the unit circle and how things translate (rotate) when put on the complex plane. this rundown from Real Python uses a (contrived) example of the Bermuda Triangle. Very tempted to adapt it with a different region of the globe. Or maybe we use a simple geometric form and how it can be flipped and rotated easier on the complex plane. URG. More thought needed on my part, clearly.