Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new
random
concept #3556new
random
concept #3556Changes from 2 commits
4ee91c6
2947331
28cc392
d0ac75d
4093f7a
33a5f90
96d1a60
999b443
18c185b
b318855
e1b6bba
f409376
4a87cdc
4756c7f
07bf0a8
d188e10
6485653
3b7c53c
2e38e78
d355185
2aaa718
5cf1dff
b801b10
df91e31
7ccdf36
72e2d7f
d8ffe3b
fed3a66
666435b
15a9211
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sigh. I want to keep this here, buuuut. If this is going to be "high" on the tree, then we can't use a list comprehension here, and instead have to do
loop-append
. But that being said, this will also be before loops. So maybe we keep it....I will have to think about it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I admit I wondered about that after submitting it, without reaching a clear conclusion.
Another thing I worry about: these are high up but absolutely depend on
import
. How do we resolve that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minutes later, with a bit more thought: this would be a killer error in
introduction.md
. Forabout.md
I think we have more leeway to forward-reference concepts the students haven't reached yet. May need an explanatory comment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Errr. Yeah. That said,
import
is really easy to show by example. At least that's what I tell myself every time it comes up. But if it is also raising concerns for you, we might want to brainstorm on how we address that.One option, of course, is to move concepts around. I like the idea of keeping math related stuff in a cluster, but I also don't want to send anyone screaming for the exit. Now, none of these are on the "critical path" of prerequisites, but a lot of folx might very well go through them because they are there.
Option two would be to briefly show & explain how you do an
import
, and hope that we don't get complaints about the hand-waving. I am not sure we would, since its really straightforward. Something along the lines of:Option three would be to write up an
import
concept. I am allergic to this for several reasons:I think I might be in favor of option two. What are your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, with the caveat that we may also need
from xxx import yyy
. I've used that a lot indatetime
, though not in the numbers cluster.Next step: when do we discourage
from xxx import *
. Presumably, after namespaces.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I might say immediately. But certainly after namespaces.