Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dnd-character #162

Merged
merged 3 commits into from
May 15, 2024
Merged

Add dnd-character #162

merged 3 commits into from
May 15, 2024

Conversation

BNAndras
Copy link
Member

@BNAndras BNAndras commented May 1, 2024

For #48in24. I defined helper functions the test suite can invoke to test the code as intended in the problem specs. I left the immutable test in to guide the students towards objects. I bumped up the difficulty as a result.

@BNAndras BNAndras added x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation labels May 1, 2024
@BNAndras BNAndras requested a review from loziniak May 1, 2024 05:45
@loziniak
Copy link
Member

loziniak commented May 1, 2024

I totally don't understand how test-character-abilities function can test if each ability is only calculated once...

@BNAndras
Copy link
Member Author

BNAndras commented May 1, 2024

While back, there apparently was a student that had a solution where the getter was not in fact a getter but instead calculated the ability score each time it was called. So the test makes sure the score doesn’t change when the getter is used. For our purposes, that test can be skipped I think.

@kotp
Copy link
Member

kotp commented May 3, 2024

I totally don't understand how test-character-abilities function can test if each ability is only calculated once...

It is likely not a bullet proof test, (I have not looked at this version of that test with the "bulletproof" criteria), but when it changes, this should pick it up, at least occasionally.

Do you want to have it exist and see how it is received by the students? That is my predisposition for something like that.

@BNAndras BNAndras merged commit 0ea7066 into exercism:main May 15, 2024
2 checks passed
@BNAndras BNAndras deleted the add-dnd-character branch May 15, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants