Add phone-number #188
Merged
Add phone-number #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BNAndras
added
x:module/practice-exercise
|
This is for the current week's featured exercise so this should take priority over the other two #48in24 PRs. Thanks! |
kotp
reviewed
Sep 22, 2024
Comment on lines
+110
to
+115
| summary: (summary) ;@@ [string!] | ||
| test-code: (copy code) ;@@ [block!] | ||
| status: none ;@@ [word!] : 'pass | 'fail | 'error | 'ignored | ||
| ;-- expected (optional field) | ||
| ;-- actual (optional field) | ||
| ;-- output (optional field) |
There was a problem hiding this comment.
Suggested change
| summary: (summary) ;@@ [string!] | |
| test-code: (copy code) ;@@ [block!] | |
| status: none ;@@ [word!] : 'pass | 'fail | 'error | 'ignored | |
| ;-- expected (optional field) | |
| ;-- actual (optional field) | |
| ;-- output (optional field) | |
| summary: (summary) ;@@ [string!] | |
| test-code: (copy code) ;@@ [block!] | |
| status: none ;@@ [word!] : 'pass | 'fail | 'error | 'ignored | |
| ;-- expected (optional field) | |
| ;-- actual (optional field) | |
| ;-- output (optional field) |
It might be "tab translation issue" here though.
There was a problem hiding this comment.
I’m not seeing the difference on my phone. Mind describing it briefly? If we update testlib.red, we’ll want to do it for all instances of it. That’d be a separate PR.
There was a problem hiding this comment.
It may be due to tabs, how it formats on the github page is "jittery". Sent you a patch.
kotp
approved these changes
Sep 22, 2024
ErikSchierboom
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #48in24