Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of leap exercise #97

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

BNAndras
Copy link
Member

@BNAndras BNAndras commented Jun 20, 2023

closes #98

@BNAndras
Copy link
Member Author

@loziniak, can I get a review / merge? I have other exercises I can port if you're available.

@loziniak
Copy link
Member

Fantastic! Just two minor comments. Sorry for being unresponsive, so much on my head lately. Perhaps you would like to have a maintainer status, to merge changes by yourself?

@BNAndras
Copy link
Member Author

Don't worry about it. Thanks for the offer, but already maintain three tracks and contribute heavily to a fourth so I've got my hands full. :)

I don't want to crowd you though. If you want additional exercises ported, I can do that and leave them for your review whenever you're up for it. If you don't, that's fine too.

@loziniak
Copy link
Member

Ok, understood. What do you think about these changes I suggested? I'll apply them if you won't do it yourself, ok?

@loziniak
Copy link
Member

Additional exercises would be great of course, I'll happily review anything you contribute :-) Also, if you have any suggestions to new exercise creation process, feel free to express that in form of issues. Your input as maintainer on other tracks is extremely valuable.

@BNAndras
Copy link
Member Author

I don't see the two comments. Were they part of a review?

@loziniak
Copy link
Member

Yes, I think so. I hope I didn't mess something up so they are not visible to you:

obraz

@loziniak loziniak merged commit a9a74c4 into exercism:main Dec 1, 2023
2 checks passed
@BNAndras BNAndras deleted the add-leap-exercise branch December 1, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement leap exercise
2 participants