Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install the current Bundler in Dockerfile #139

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Install the current Bundler in Dockerfile #139

merged 2 commits into from
Mar 5, 2024

Conversation

smaboshe
Copy link
Contributor

In Dockerfile, we have been specifying the exact Bundler version to install. This is no longer necessary.

This commit updates Dockerfile to install the current version of Bundler. Bundler will then take care of setting up the correct version to use.

Ref:

In `Dockerfile`, we have been specifying the exact Bundler version to
install. This is no longer necessary.

This commit updates `Dockerfile` to install the current version of
Bundler. Bundler will then take care of setting up the correct version
to use.

Ref:
- exercism/ruby#1635 (comment)
@smaboshe smaboshe requested a review from a team as a code owner February 15, 2024 07:48
Copy link

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@kotp
Copy link
Member

kotp commented Feb 15, 2024

This is no longer necessary.

It is is likely necessary. Knowing the version we are requiring gives a lot of information. Having a possible "latest version" does not let us brace against breaking changes, for example.

We should specify the version, and it should allow us to cache information as well. Including using bundle _x.x.x_ install --local if we end up caching the gems as well. (Speed for spinning up while having some flexibility, the cost being storage vs network transfer).

@Hunk13
Copy link

Hunk13 commented Feb 16, 2024

In my opinion, it would be great to parse the bundler version from Gemfile.lock and pass it into gem install bundler command like this.

RUN gem install bundler -v "$(grep -A 1 "BUNDLED WITH" Gemfile.lock | tail -n 1)"

in this case we will be sure that the bundler version is the same as in Gemfile.lock file.

@ErikSchierboom
Copy link
Member

RUN gem install bundler -v "$(grep -A 1 "BUNDLED WITH" Gemfile.lock | tail -n 1)"

That sounds gopd. Could you update the PR?

@smaboshe
Copy link
Contributor Author

smaboshe commented Mar 5, 2024

That sounds gopd. Could you update the PR?

Done.

@ErikSchierboom ErikSchierboom merged commit ac50641 into exercism:main Mar 5, 2024
3 checks passed
iHiD added a commit that referenced this pull request Mar 5, 2024
iHiD added a commit that referenced this pull request Mar 5, 2024
@smaboshe smaboshe deleted the smaboshe-install-current-bundler-in-dockerfile branch March 6, 2024 04:33
@smaboshe
Copy link
Contributor Author

smaboshe commented Mar 6, 2024

Thank you for merging this PR.

I see that it was reverted.

Would it be possible to have context for the revert? Did this break CI or deployment?

I can't seem to find any background for the revert here or in the discussion forum.

@smaboshe
Copy link
Contributor Author

smaboshe commented Mar 6, 2024

I have been able to find some context:

What tools are available that would have allowed me to see this issue earlier?

@kotp
Copy link
Member

kotp commented Mar 6, 2024

I have been able to find some context:

What tools are available that would have allowed me to see this issue earlier?

Subscribing to forum, the Ruby category, would have probably given you some indication early.

Subscribing to the github notifications for projects can be another way for timely notifications.

ErikSchierboom added a commit that referenced this pull request Mar 6, 2024
ErikSchierboom added a commit that referenced this pull request Mar 6, 2024
@ErikSchierboom
Copy link
Member

I've reverted the revert :)

@smaboshe
Copy link
Contributor Author

smaboshe commented Mar 6, 2024

Thank you, @ErikSchierboom.

I imagine that you are able to see that things are working from your end. If this PR breaks things, I would be interested to know what the issue is. Thanks again!

@smaboshe
Copy link
Contributor Author

smaboshe commented Mar 6, 2024

Subscribing to forum, the Ruby category, would have probably given you some indication early.

Subscribing to the github notifications for projects can be another way for timely notifications.

Thank you, @kotp. I have subscribed to these.

@iHiD
Copy link
Member

iHiD commented Mar 6, 2024

If this PR breaks things, I would be interested to know what the issue is.

It didn't. I basically just reverted anything merged in the last 24 hours to get things back to a working state. I should probably have commented, but it was late at night, urgent, and I knew Erik would tidy up my mess today so I was lazy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants