-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install the current Bundler in Dockerfile
#139
Install the current Bundler in Dockerfile
#139
Conversation
In `Dockerfile`, we have been specifying the exact Bundler version to install. This is no longer necessary. This commit updates `Dockerfile` to install the current version of Bundler. Bundler will then take care of setting up the correct version to use. Ref: - exercism/ruby#1635 (comment)
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
It is is likely necessary. Knowing the version we are requiring gives a lot of information. Having a possible "latest version" does not let us brace against breaking changes, for example. We should specify the version, and it should allow us to cache information as well. Including using |
In my opinion, it would be great to parse the bundler version from
in this case we will be sure that the bundler version is the same as in |
That sounds gopd. Could you update the PR? |
Done. |
Thank you for merging this PR. I see that it was reverted. Would it be possible to have context for the revert? Did this break CI or deployment? I can't seem to find any background for the revert here or in the discussion forum. |
I have been able to find some context:
What tools are available that would have allowed me to see this issue earlier? |
Subscribing to forum, the Ruby category, would have probably given you some indication early. Subscribing to the github notifications for projects can be another way for timely notifications. |
I've reverted the revert :) |
Thank you, @ErikSchierboom. I imagine that you are able to see that things are working from your end. If this PR breaks things, I would be interested to know what the issue is. Thanks again! |
Thank you, @kotp. I have subscribed to these. |
It didn't. I basically just reverted anything merged in the last 24 hours to get things back to a working state. I should probably have commented, but it was late at night, urgent, and I knew Erik would tidy up my mess today so I was lazy :) |
In
Dockerfile
, we have been specifying the exact Bundler version to install. This is no longer necessary.This commit updates
Dockerfile
to install the current version of Bundler. Bundler will then take care of setting up the correct version to use.Ref: