Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom lints with clippy #70

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Replace custom lints with clippy #70

merged 1 commit into from
Aug 13, 2024

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Aug 9, 2024

No description provided.

@senekor
Copy link
Contributor Author

senekor commented Aug 9, 2024

Total docker image size: 783 MB

  • debian base: 75 MB
  • basic rust toolchain: 695 MB
  • clippy: 13 MB

Comment on lines +1 to +11
{
"comments": [
{
"comment": "rust.general.clippy",
"params": {
"clippy_msg": "warning: `--x` could be misinterpreted as pre-decrement by C programmers, is usually a no-op\n --> src/lib.rs:2:5\n |\n2 | --x\n | ^^^\n |\n = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_neg\n = note: `#[warn(clippy::double_neg)]` on by default"
},
"type": "informative"
}
]
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example output. If I interpreted the spec correctly, it should hopefully match.

@senekor
Copy link
Contributor Author

senekor commented Aug 9, 2024

relevant forum discussion

@senekor senekor marked this pull request as ready for review August 9, 2024 13:18
@senekor senekor requested a review from a team as a code owner August 9, 2024 13:18
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the deletion of the non-specific inputs and now having well-named ones 👍

@senekor senekor merged commit 8d82c0f into main Aug 13, 2024
1 check passed
@senekor senekor deleted the clippy branch August 13, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants