chore: add bindings to length_unsafe #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G4Vi
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
This looks good. However, I could also incorporate this into #18 In there since I made extism_length take an ExtismHandle, I was thinking making extism_length map to importing length_unsafe and adding extism_length_checked or extism_length_safe which would take an ExtismPointer and map to length. Given that no one should be performing arithmetic on an ExtismHandle, I figured it would be reasonable.
|
@G4Vi we can just skip this PR then - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.