Heretic: update P_GroupLines and (re-)create BLOCKMAP if necessary (#… #596
Annotations
10 warnings and 2 notices
src/heretic/p_blockmap.c:28:6 [readability-function-cognitive-complexity]:
src/heretic/p_blockmap.c#L28
function 'P_CreateBlockMap' has cognitive complexity of 51 (threshold 25)
|
src/heretic/p_blockmap.c:30:16 [cppcoreguidelines-init-variables]:
src/heretic/p_blockmap.c#L30
variable 'i' is not initialized
|
src/heretic/p_blockmap.c:30:16 [readability-identifier-length]:
src/heretic/p_blockmap.c#L30
variable name 'i' is too short, expected at least 3 characters
|
src/heretic/p_blockmap.c:31:3 [readability-isolate-declaration]:
src/heretic/p_blockmap.c#L31
multiple declarations in a single statement reduces readability
|
src/heretic/p_blockmap.c:37:44 [readability-braces-around-statements]:
src/heretic/p_blockmap.c#L37
statement should be inside braces
|
src/heretic/p_blockmap.c:40:39 [readability-braces-around-statements]:
src/heretic/p_blockmap.c#L40
statement should be inside braces
|
src/heretic/p_blockmap.c:42:44 [readability-braces-around-statements]:
src/heretic/p_blockmap.c#L42
statement should be inside braces
|
src/heretic/p_blockmap.c:45:39 [readability-braces-around-statements]:
src/heretic/p_blockmap.c#L45
statement should be inside braces
|
src/heretic/p_blockmap.c:57:19 [clang-analyzer-core.UndefinedBinaryOperatorResult]:
src/heretic/p_blockmap.c#L57
The result of the left shift is undefined because the left operand is negative
|
src/heretic/p_blockmap.c:57:19 [clang-analyzer-core.UndefinedBinaryOperatorResult]:
src/heretic/p_blockmap.c#L57
The result of the left shift is undefined due to shifting '2147483647' by '16', which is unrepresentable in the unsigned version of the return type 'fixed_t'
|
Run clang-format on src/heretic/p_blockmap.c:
src/heretic/p_blockmap.c#L1
File src/heretic/p_blockmap.c does not conform to Custom style guidelines. (lines 29, 30, 31, 33, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 53, 55, 57, 58, 59, 60, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 79, 80, 81, 82, 83, 85, 86, 87, 89, 90, 91, 93, 94, 95, 97, 98, 99, 100, 101, 102, 104, 105, 107, 108, 109, 111, 112, 114, 115, 116, 118, 119, 120, 121, 122, 123, 124, 125, 127, 128, 130, 131, 132, 134, 135, 136, 137, 138, 139, 140, 142, 143, 144, 145, 146, 147, 149, 150, 152, 153, 154, 156, 157, 158, 160, 161, 162, 163, 165, 166, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 181, 182, 183, 185, 186, 187, 188, 189, 190, 191)
|
Run clang-format on src/heretic/p_setup.c:
src/heretic/p_setup.c#L1
File src/heretic/p_setup.c does not conform to Custom style guidelines. (lines 525, 527, 628, 632, 650, 659, 805)
|