Resolution-tuned weapon sprite 1 pixel height adjustment for compatibility with bit-shifting hires forks #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Why "sorry", did @JNechaevsky suggest a different approach? |
Yes, the previous fix was if not suggested then at least bugreported by her: |
|
I see. And your approach works for normal, double and quad resolution? |
Yes, quite right :) |
|
Actually, I can confirm this issue exist, but not happening in Crispy's 1x/2x resolutions. Here's my approach, where But which one is better and fits better for Crispy - honestly, no idea, so I didn't suggest it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
FRACUNIT/(2<<crispy->hires)instead ofFRACUNIT/constant.Sorry @JNechaevsky, flexible solutions are usually better.