Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strife: fix "Name Your Character" menu #1203

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Strife: fix "Name Your Character" menu #1203

merged 1 commit into from
Jun 15, 2024

Conversation

JNechaevsky
Copy link
Collaborator

My bad, brought by Save/Load menu centering/rearrangement and always using crispy-strife.exe -loadgame 0 for faster startup.

Before and after:

image
image

Copy link
Owner

@fabiangreffrath fabiangreffrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JNechaevsky JNechaevsky merged commit 79949ce into master Jun 15, 2024
5 checks passed
@JNechaevsky JNechaevsky deleted the strife_namechar branch June 15, 2024 20:44
@JNechaevsky
Copy link
Collaborator Author

Good news: I was finally able to properly implement epic crossfading effect in TrueColor. No more magic numbers, less agressive for loop running and decent smooth blending:

bandicam.2024-06-15.23-43-05-852.mp4

Here it is in Hexen's code for cleaner view. But very brief attempt to port it to Crispy Strife wasn't as good as it should, it feels like fading happens faster there, with still nag delay in the end. Very weird. ☹️ I'll have to investigate it, as well as double check the situation if memory leak really happens or not.

Haven't touched paletted crossfade though, but something tells me that real improvement for 256 color is possible only by using v_flextran.c, but it's dual-licensed, so probably better don't use it for Crispy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants