Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes memory leak (over-consumption) by toggling detail mode or changing screen size. Few remarks:
Small note - it was barely possible to notice a leak while non-TrueColor build, obliviously because of smaller
lighttable_t
size. However, while experimenting with colored lighting and having 28 extra colormaps (bothscalelight
andzlight
, TrueColor only approach), such leak costs about ~400 kilobytes every timeR_ExecuteSetViewSize
was hit! Never thought such experiments will be that useful. 🙂