Add external authorization via http request #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to Envoys external authorization[0], and can be used for example in combination with Ory Oathkeeper. [0] https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/ext_authz/v3/ext_authz.proto
nathanejohnson
force-pushed
the
master
branch
2 times, most recently
from
a55de9d to
04f958c
Compare
|
👍 for this PR! Maybe a future refinement would be to use service-discovery to discover the endpoint by service name? But I'd take this as is now to get the ball rolling, have the same use-case in mind. |
nathanejohnson
requested changes
Nov 17, 2022
| } | ||
|
|
||
| func (b *external) Authorized(request *http.Request, response http.ResponseWriter) AuthDecision { | ||
| client := &http.Client{CheckRedirect: func(req *http.Request, via []*http.Request) error { return http.ErrUseLastResponse }} |
There was a problem hiding this comment.
This client should specify a timeout at least, and possibly a transport too depending on whether tls configurations would need to be overridden. Also, it would be much better to store this client inside the external struct instead of recreating it each time.
| log.Println("[ERROR] External request error:", err.Error()) | ||
| return unauthorized() | ||
| } | ||
|
|
There was a problem hiding this comment.
resp.Body is never drained or closed. if err is nil, body needs to be dealt with.
|
|
||
| if strings.HasSuffix(a.External.Endpoint, "/") { |
There was a problem hiding this comment.
Curious to the reasoning for this restriction?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to Envoys external authorization, and can be used for example in combination with Ory Oathkeeper.