Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundant lombok.Setter and lombok.experimental.Accessors annotations #5566

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

manusa
Copy link
Member

@manusa manusa commented Nov 2, 2023

Description

Fixes #5564

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

… annotations

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa added this to the 6.9.2 milestone Nov 2, 2023
@@ -3,6 +3,9 @@
### 6.10-SNAPSHOT

#### Bugs
* Fix #5560: bump com.marcnuri.plugins:gradle-api-maven-plugin to v0.0.5, allows compilation behind a proxy
* Fix #5564: remove redundant lombok.Setter and lombok.experimental.Accessors annotations
* Fix #5565: bump sundrio to 0.101.3 to fix Visitor problems
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is normal that it covers other fixes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I added the changelog for the rest of things that will go into 6.9.2.
I want to get started with the release ASAP

@shawkins
Copy link
Contributor

shawkins commented Nov 2, 2023

There were originally added due to a builder issue with not cloning the additionalProperties, let me see if that still applies.

@manusa
Copy link
Member Author

manusa commented Nov 2, 2023

There were originally added due to a builder issue with not cloning the additionalProperties, let me see if that still applies.

I'll wait for your green light then

Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the generator has it's own logic for adding an additionalProperties setter.

@manusa manusa merged commit b4c783f into fabric8io:main Nov 2, 2023
19 of 20 checks passed
@manusa manusa deleted the fix/java-generator-lombok branch November 2, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sundrio bump to 0.101.3 causes problems with cert-manager generated code (getClass)
6 participants