-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove redundant lombok.Setter and lombok.experimental.Accessors annotations #5566
Conversation
… annotations Signed-off-by: Marc Nuri <marc@marcnuri.com>
@@ -3,6 +3,9 @@ | |||
### 6.10-SNAPSHOT | |||
|
|||
#### Bugs | |||
* Fix #5560: bump com.marcnuri.plugins:gradle-api-maven-plugin to v0.0.5, allows compilation behind a proxy | |||
* Fix #5564: remove redundant lombok.Setter and lombok.experimental.Accessors annotations | |||
* Fix #5565: bump sundrio to 0.101.3 to fix Visitor problems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is normal that it covers other fixes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I added the changelog for the rest of things that will go into 6.9.2.
I want to get started with the release ASAP
There were originally added due to a builder issue with not cloning the additionalProperties, let me see if that still applies. |
I'll wait for your green light then |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the generator has it's own logic for adding an additionalProperties setter.
Description
Fixes #5564
Type of change
test, version modification, documentation, etc.)
Checklist