Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Variable Names for P100(Max) Latency in Cachebench #368

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Variable Names for P100(Max) Latency in Cachebench #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cachelib/cachebench/cache/Cache.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1234,7 +1234,7 @@ Stats Cache<Allocator>::getStats() const {
lookup("navy_device_read_latency_us_p99999");
ret.nvmReadLatencyMicrosP999999 =
lookup("navy_device_read_latency_us_p999999");
ret.nvmReadLatencyMicrosP100 = lookup("navy_device_read_latency_us_p100");
ret.nvmReadLatencyMicrosMax = lookup("navy_device_read_latency_us_max");
ret.nvmWriteLatencyMicrosP50 = lookup("navy_device_write_latency_us_p50");
ret.nvmWriteLatencyMicrosP90 = lookup("navy_device_write_latency_us_p90");
ret.nvmWriteLatencyMicrosP99 = lookup("navy_device_write_latency_us_p99");
Expand All @@ -1245,7 +1245,7 @@ Stats Cache<Allocator>::getStats() const {
lookup("navy_device_write_latency_us_p99999");
ret.nvmWriteLatencyMicrosP999999 =
lookup("navy_device_write_latency_us_p999999");
ret.nvmWriteLatencyMicrosP100 = lookup("navy_device_write_latency_us_p100");
ret.nvmWriteLatencyMicrosMax = lookup("navy_device_write_latency_us_max");
ret.numNvmItemRemovedSetSize = lookup("items_tracked_for_destructor");

// track any non-zero check sum errors or io errors
Expand Down
8 changes: 4 additions & 4 deletions cachelib/cachebench/cache/CacheStats.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,15 +97,15 @@ struct Stats {
double nvmReadLatencyMicrosP9999{0};
double nvmReadLatencyMicrosP99999{0};
double nvmReadLatencyMicrosP999999{0};
double nvmReadLatencyMicrosP100{0};
double nvmReadLatencyMicrosMax{0};
double nvmWriteLatencyMicrosP50{0};
double nvmWriteLatencyMicrosP90{0};
double nvmWriteLatencyMicrosP99{0};
double nvmWriteLatencyMicrosP999{0};
double nvmWriteLatencyMicrosP9999{0};
double nvmWriteLatencyMicrosP99999{0};
double nvmWriteLatencyMicrosP999999{0};
double nvmWriteLatencyMicrosP100{0};
double nvmWriteLatencyMicrosMax{0};

uint64_t numNvmExceededMaxRetry{0};

Expand Down Expand Up @@ -317,7 +317,7 @@ struct Stats {
fmtLatency(readCat, "p9999", nvmReadLatencyMicrosP9999);
fmtLatency(readCat, "p99999", nvmReadLatencyMicrosP99999);
fmtLatency(readCat, "p999999", nvmReadLatencyMicrosP999999);
fmtLatency(readCat, "p100", nvmReadLatencyMicrosP100);
fmtLatency(readCat, "max", nvmReadLatencyMicrosMax);

fmtLatency(writeCat, "p50", nvmWriteLatencyMicrosP50);
fmtLatency(writeCat, "p90", nvmWriteLatencyMicrosP90);
Expand All @@ -326,7 +326,7 @@ struct Stats {
fmtLatency(writeCat, "p9999", nvmWriteLatencyMicrosP9999);
fmtLatency(writeCat, "p99999", nvmWriteLatencyMicrosP99999);
fmtLatency(writeCat, "p999999", nvmWriteLatencyMicrosP999999);
fmtLatency(writeCat, "p100", nvmWriteLatencyMicrosP100);
fmtLatency(writeCat, "max", nvmWriteLatencyMicrosMax);

constexpr double GB = 1024.0 * 1024 * 1024;
double appWriteAmp =
Expand Down