Fix continuous data path mode RETRY edge case

Summary: We need to reset the buf accessor here as well. Reviewed By: sharmafb Differential Revision: D67472070 fbshipit-source-id: 1700b38e448ca6194a7bd9c034cbbfb6bad727d5
facebook · Dec 19, 2024 · da45380 · da45380
1 parent f5de29c
commit da45380
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/quic/client/state/ClientStateMachine.cpp b/quic/client/state/ClientStateMachine.cpp
@@ -63,6 +63,7 @@ std::unique_ptr<QuicClientConnectionState> undoAllClientStateForRetry(
   newConn->earlyDataAppParamsGetter = std::move(conn->earlyDataAppParamsGetter);
   newConn->happyEyeballsState = std::move(conn->happyEyeballsState);
   newConn->flowControlState = std::move(conn->flowControlState);
+  newConn->bufAccessor = conn->bufAccessor;
   newConn->pendingOneRttData.reserve(
       newConn->transportSettings.maxPacketsToBuffer);
   if (conn->congestionControllerFactory) {

diff --git a/quic/fizz/client/test/QuicClientTransportTest.cpp b/quic/fizz/client/test/QuicClientTransportTest.cpp
@@ -110,6 +110,8 @@ class QuicClientTransportIntegrationTest : public TestWithParam<TestingParams> {
     auto transportSettings = client->getTransportSettings();
     transportSettings.attemptEarlyData = true;
     transportSettings.removeStreamAfterEomCallbackUnset = true;
+    transportSettings.dataPathType = DataPathType::ContinuousMemory;
+    transportSettings.batchingMode = QuicBatchingMode::BATCHING_MODE_GSO;
     client->setTransportSettings(transportSettings);
     return client;
   }