Skip to content

Commit

Permalink
Fix QuicTransportTest
Browse files Browse the repository at this point in the history
Summary: An unused folly timer fd keeps the event base active causing the tests to timeout. This fixes it.

Differential Revision: D52647419

fbshipit-source-id: 57e699e9b34c9fd6d86cb6e0cb1705066f09e1c9
  • Loading branch information
jbeshay authored and facebook-github-bot committed Jan 10, 2024
1 parent 697ab96 commit e8eff25
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions quic/api/test/QuicTransportTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ class QuicTransportTest : public Test {
public:
QuicTransportTest() {
qEvb_ = std::make_shared<FollyQuicEventBase>(&evb_);
qTimer_ = std::make_unique<HighResQuicTimer>(
&evb_, evb_.timer().getTickInterval());
}
~QuicTransportTest() override = default;

Expand Down Expand Up @@ -124,7 +122,6 @@ class QuicTransportTest : public Test {
protected:
folly::EventBase evb_;
std::shared_ptr<FollyQuicEventBase> qEvb_;
std::unique_ptr<HighResQuicTimer> qTimer_;
MockAsyncUDPSocket* socket_;
NiceMock<MockConnectionSetupCallback> connSetupCallback_;
NiceMock<MockConnectionCallback> connCallback_;
Expand Down

0 comments on commit e8eff25

Please sign in to comment.