Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update colors for table of contents to be more in line with the theme #4412

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Jan 2, 2025

Revise the custom theme colors to enhance the appearance of the table of contents and code elements.

before
image

after
image

image

before
image

after
image

image

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 3c8d92f
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/677d5daef46dd300085462ec
😎 Deploy Preview https://deploy-preview-4412--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hichemfantar hichemfantar changed the title Update theme colors for table of contents and code elements Update colors for table of contents to be more in line with the theme Jan 2, 2025
@hichemfantar hichemfantar marked this pull request as ready for review January 2, 2025 20:15
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 @Simek what do you think?

@Simek
Copy link
Collaborator

Simek commented Jan 4, 2025

I think that light mode indicator and entry appearance is less contrasty and harder to spot than before the changes.

If we decided that we want to change the sidebar entries, I would try to align them with react.dev design, which represent the most up-to-date patterns.

@hichemfantar
Copy link
Contributor Author

I updated the colors for the light theme to have better contrast and included a contrast check report as well.
let me know what you think.

@Simek
Copy link
Collaborator

Simek commented Jan 7, 2025

Thanks for the updates! IMHO it looks better after the last iteration, left two nits above.

@hichemfantar
Copy link
Contributor Author

@Simek You're welcome! All requested changes have been implemented 🚀

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates, LGTM! 👍

@Simek Simek merged commit e2c7303 into facebook:main Jan 7, 2025
4 checks passed
@hichemfantar hichemfantar deleted the table-of-contents-better-styles branch January 7, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants