-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update colors for table of contents to be more in line with the theme #4412
Update colors for table of contents to be more in line with the theme #4412
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 @Simek what do you think?
I think that light mode indicator and entry appearance is less contrasty and harder to spot than before the changes. If we decided that we want to change the sidebar entries, I would try to align them with react.dev design, which represent the most up-to-date patterns. |
I updated the colors for the light theme to have better contrast and included a contrast check report as well. |
Thanks for the updates! IMHO it looks better after the last iteration, left two nits above. |
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
@Simek You're welcome! All requested changes have been implemented 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates, LGTM! 👍
Revise the custom theme colors to enhance the appearance of the table of contents and code elements.
before
after
before
after