Skip to content

Commit

Permalink
don't mark methods overridden by a root as root.
Browse files Browse the repository at this point in the history
Summary: I can't think of a reason why. It doesn't seem to affect anything either.

Reviewed By: agampe

Differential Revision: D49800673

fbshipit-source-id: b06c47857fe6fa29d64207615d7b753ce9e26b0f
  • Loading branch information
Nikolai Tillmann authored and facebook-github-bot committed Oct 17, 2023
1 parent 392c265 commit 52b94a1
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions libredex/CallGraph.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,6 @@ RootAndDynamic MultipleCalleeBaseStrategy::get_roots() const {
for (auto overriding_method : overriding_methods) {
add_root_method_overrides(overriding_method);
}
const auto& overiden_methods =
mog::get_overridden_methods(m_method_override_graph, method);
for (auto overiden_method : overiden_methods) {
add_root_method_overrides(overiden_method);
}
});
// Gather methods that override or implement external or native methods
// as well.
Expand Down Expand Up @@ -271,11 +266,6 @@ RootAndDynamic CompleteCallGraphStrategy::get_roots() const {
for (auto overriding_method : overriding_methods) {
add_root_method_overrides(overriding_method);
}
const auto& overiden_methods =
mog::get_overridden_methods(m_method_override_graph, method);
for (auto overiden_method : overiden_methods) {
add_root_method_overrides(overiden_method);
}
});
// Gather methods that override or implement external methods
for (auto& pair : m_method_override_graph.nodes()) {
Expand Down

0 comments on commit 52b94a1

Please sign in to comment.