Skip to content

Commit

Permalink
Switch pyre check to target based and fix some errors.
Browse files Browse the repository at this point in the history
Summary:
Following pradeep90 advice from https://fb.workplace.com/groups/pyreqa/posts/6602900829779645/?comment_id=6617709958298732 and switch Redex to buck based pyre:
1. allows to include more targets.
2. finds one missed import `fbsource//third-party/pypi/ipython:ipython`.
3. makes many suppressions unneeded.

However, I am not an expert in either Redex or Pyre so treat this diff like it was written by LLM.

Reviewed By: agampe

Differential Revision: D50399037

fbshipit-source-id: e035bae47414ad2abc20821ca7628ba9cbb07c60
  • Loading branch information
sandreenko authored and facebook-github-bot committed Oct 18, 2023
1 parent 5404b10 commit f9ab592
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
2 changes: 0 additions & 2 deletions redex.py
Original file line number Diff line number Diff line change
Expand Up @@ -940,7 +940,6 @@ def _check_shrinker_heuristics(args: argparse.Namespace) -> None:
# Nothing found, check whether we have files embedded
logging.info("No shrinking heuristic found, searching for default.")
try:
# pyre-ignore[21]
from generated_shrinker_regalloc_heuristics import SHRINKER_HEURISTICS_FILE

logging.info("Found embedded shrinker heuristics")
Expand All @@ -965,7 +964,6 @@ def _check_android_sdk_api(args: argparse.Namespace) -> None:
# Nothing found, check whether we have files embedded
logging.info("No android_sdk_api_XX_file parameters found.")
try:
# pyre-ignore[21]
import generated_apilevels as ga

levels = ga.get_api_levels()
Expand Down
12 changes: 6 additions & 6 deletions tools/python/symbolicator/symbolicator.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
import signal
import sys

from debug_line_map import DebugLineMap # pyre-fixme[21]
from dexdump import DexdumpSymbolicator # pyre-fixme[21]
from iodi import IODIMetadata # pyre-fixme[21]
from line_unmap import PositionMap # pyre-fixme[21]
from logcat import LogcatSymbolicator # pyre-fixme[21]
from symbol_files import SymbolFiles # pyre-fixme[21]
from debug_line_map import DebugLineMap
from dexdump import DexdumpSymbolicator
from iodi import IODIMetadata
from line_unmap import PositionMap
from logcat import LogcatSymbolicator
from symbol_files import SymbolFiles


# A simple symbolicator for line-based input,
Expand Down

0 comments on commit f9ab592

Please sign in to comment.