Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Development] [WIP] Add new api for getting and setting object states which supports custom serialization #1975

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MatthewChang
Copy link
Contributor

@MatthewChang MatthewChang commented May 30, 2024

Adds a new api for getting and setting object states which supports custom serialization

Motivation and Context

This will allow us to

  1. query the state of a single object while still injecting the default value when necessary. and
  2. Support compound/non-primitive state values for object states.

How Has This Been Tested

Unit testing

Checklist

  • [ x] My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • [ x] I have completed my CLA (see CONTRIBUTING)
  • [x ] I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 30, 2024
@MatthewChang MatthewChang changed the title **\[Development\]** Add new api for getting and setting object states which supports custom serialization \[Development\] Add new api for getting and setting object states which supports custom serialization May 30, 2024
@MatthewChang MatthewChang changed the title \[Development\] Add new api for getting and setting object states which supports custom serialization [Development] [WIP] Add new api for getting and setting object states which supports custom serialization May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants