Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render mock data #40

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Render mock data #40

wants to merge 10 commits into from

Conversation

Heathercoraje
Copy link
Collaborator

@Heathercoraje Heathercoraje commented Oct 3, 2017 •
edited by matthewdking
Loading

relates #30

@codecov
Copy link

codecov bot commented Oct 3, 2017 •
edited
Loading

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #40   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           6      6           
=====================================
  Hits            6      6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae5484a...130b439. Read the comment docs.

matthewdking
matthewdking reviewed Oct 3, 2017
View reviewed changes
database/db_build.js Outdated
});
var dataLength = 0;
for (var i = 0; i < careers.length; i++) {
careers[i].save((error, result) => {
Copy link
Collaborator

@matthewdking matthewdking Oct 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some research and found out that save is a wrapper for insert and update, see this. If this is true then we could get rid of the for loop and use insertMany() instead.

heathercoraje and others added 6 commits October 4, 2017 11:45
building data
9a5b019
render mock data
8816220 
yet still in progress for adding codes for drop schema
render mock data
20b5502 
yet still in progress for adding codes for drop schema
solves merge conflicts
d42cd3c 
relates #30
adds render error page to career.js
cfa6303 
relates #30
changes to err for consistency
1ec5cf3 
relates #30
@matthewdking matthewdking changed the title [WIP] render mock data Render mock data Oct 4, 2017
@ghost ghost assigned Karyum Oct 4, 2017
@ghost ghost requested a review from jwld October 4, 2017 12:08
@ghost ghost unassigned Karyum Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdking matthewdking matthewdking approved these changes

@veredrec veredrec veredrec approved these changes

@sajedazoabi sajedazoabi Awaiting requested review from sajedazoabi

@jwld jwld Awaiting requested review from jwld

Assignees
No one assigned
Labels
awaiting-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Heathercoraje @veredrec @matthewdking @Karyum