fix condominium_fiscal_code generator length from 9 to 11 characters #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FiloSpaTeam
changed the title
| @@ -101,7 +101,7 @@ def stock_market | |||
| # @return [String] | |||
| # | |||
| # @example | |||
| # Faker::Finance.condominium_fiscal_code #=> "012345678" | |||
| # Faker::Finance.condominium_fiscal_code #=> "01234567890" | |||
There was a problem hiding this comment.
Might be worth updating the doc for this as well:
# @param country [String] Two capital letter country code to use for the vat number.
becomes:
# @param country [String] Two capital letter country code to use for the condominium fiscal code number.
There was a problem hiding this comment.
ok i noticed, it is wrong. I need to update it. Thx
stefannibrasil
added
⌛ PR: Needs More Information
The condominium is a juridical person so has 11 character length (only number). Check page 4 (italian version but from Agenzia delle Entrate)
|
the real length of a condominium fiscal_code is 11 and not 9: the first 7 numbers identify the condominium, the later 3 identify the office and the latest is the control character
FiloSpaTeam
force-pushed
the
fix/condominium_fiscal_code
branch
from
a21ac40 to
c42cbec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because the real length of a condominium fiscal_code in Italy is 11 and not 9: the first 7 numbers identify the condominium, the later 3 identify the office and the latest is the control character
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]If you're proposing a new generator or locale: