Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dhedge.org to the Safe Connector allowed domains list #441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dimlbc
Copy link

@dimlbc dimlbc commented Jan 9, 2025

dHEDGE managers connect to Aave via Gnosis Safe SDK, and Aave integrates with connectkit. The current domain restriction blocks dHEDGE managers from connecting to Aave using the Safe Connector impacting their ability to efficiently manage assets on Aave.

This PR whitelists dhedge.org for the Safe App Connector and introduces safeWalletAllowedDomains prop in defaultConfig, which allows customizing allowed domains for the Safe wallet.

Copy link

vercel bot commented Jan 9, 2025

@dimlbc is attempting to deploy a commit to the Avara Team on Vercel.

A member of the Team first needs to authorize it.

@lochie
Copy link
Member

lochie commented Jan 9, 2025

Hey @dimlbc, thanks for the PR! Just wondering if this is a change that is necessary only for the Aave interface? If so we can update that app directly with this config rather than implementing it directly into ConnectKit's defaults.

@dimlbc
Copy link
Author

dimlbc commented Jan 9, 2025

Hey @dimlbc, thanks for the PR! Just wondering if this is a change that is necessary only for the Aave interface? If so we can update that app directly with this config rather than implementing it directly into ConnectKit's defaults.

Thanks for the quick response. Yes, for now Aave is the only dApp used by dHEDGE with connectkit under the hood.
I will remove dhedge.org from the default safeWalletAllowedDomains value.

UPD: done

…ntroduce safeWalletAllowedDomains in default config props
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
connectkit-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 1:57am

@lochie
Copy link
Member

lochie commented Jan 10, 2025

@dimlbc I've made a PR on Aave Interface, could you confirm that the domain is correct?
aave/interface#2310

https://github.com/aave/interface/pull/2310/files#diff-351d0c9baa2f7eb09801dc910952732fe64631e7161028bd63eefe6a65e07ec2R115

I'll also look at merging this PR here to make this easier for devs in the future.

@dimlbc
Copy link
Author

dimlbc commented Jan 10, 2025

@dimlbc I've made a PR on Aave Interface, could you confirm that the domain is correct? aave/interface#2310

https://github.com/aave/interface/pull/2310/files#diff-351d0c9baa2f7eb09801dc910952732fe64631e7161028bd63eefe6a65e07ec2R115

I'll also look at merging this PR here to make this easier for devs in the future.

thanks for the PR!
domain is correct, it is https://dhedge.org/

@lochie
Copy link
Member

lochie commented Jan 10, 2025

thanks for the PR! domain is correct, it is https://dhedge.org/

@dimlbc that PR has been merged and should be live on app.aave.com. this should hopefully resolve the issue for now 🫡

@dimlbc
Copy link
Author

dimlbc commented Jan 10, 2025

@lochie works as expected 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants