-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dhedge.org to the Safe Connector allowed domains list #441
base: main
Are you sure you want to change the base?
Conversation
@dimlbc is attempting to deploy a commit to the Avara Team on Vercel. A member of the Team first needs to authorize it. |
Hey @dimlbc, thanks for the PR! Just wondering if this is a change that is necessary only for the Aave interface? If so we can update that app directly with this config rather than implementing it directly into ConnectKit's defaults. |
Thanks for the quick response. Yes, for now Aave is the only dApp used by dHEDGE with connectkit under the hood. UPD: done |
…ntroduce safeWalletAllowedDomains in default config props
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@dimlbc I've made a PR on Aave Interface, could you confirm that the domain is correct? I'll also look at merging this PR here to make this easier for devs in the future. |
thanks for the PR! |
@dimlbc that PR has been merged and should be live on app.aave.com. this should hopefully resolve the issue for now 🫡 |
@lochie works as expected 🙌 |
dHEDGE managers connect to Aave via Gnosis Safe SDK, and Aave integrates with connectkit. The current domain restriction blocks dHEDGE managers from connecting to Aave using the Safe Connector impacting their ability to efficiently manage assets on Aave.
This PR whitelists
dhedge.org
for the Safe App Connector and introducessafeWalletAllowedDomains
prop indefaultConfig
, which allows customizing allowed domains for the Safe wallet.