Call Rainbow instead of Colorize #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request #120 removed Colorize in favor of Rainbow, `bundle_report/ruby_version_compatibility.rb` was using Colorize and we need to update it to use Rainbow
JuanVqz
force-pushed
the
fix-colorize-calls
branch
from
70dc261 to
d6daf4d
Compare
|
@etagwerker failing test are related to Rainbow not supporting Ruby 2, mentioned here |
etagwerker
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Call Rainbow instead of Colorize in
bundle_report/ruby_version_compatibility.rbMotivation and Context
Recentry the #120 PR removed Colorize in favor of Rainbow,
bundle_report/ruby_version_compatibility.rbwas using Colorize and we need to update it to use Rainbow.How Has This Been Tested?
Some tests were failing because of this, now they are passing.
Screenshots:
I will abide by the code of conduct