Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add empty pages+ add hover on cartItem button #51

Merged
merged 2 commits into from
Dec 19, 2023
Merged

add empty pages+ add hover on cartItem button #51

merged 2 commits into from
Dec 19, 2023

Conversation

OlhaKoziuk
Copy link
Contributor

@OlhaKoziuk OlhaKoziuk commented Dec 19, 2023 •
edited
Loading

dsfreedom
dsfreedom approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@dsfreedom dsfreedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible work!!!

About animations, first looks fun but maybe too much fun. I honestly like both

src/modules/FavoritesPage/FavoritesPage.tsx

<ProductList phones={favorites} />
</section>
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to remove this space if possible)

mpohorenyi
mpohorenyi approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@mpohorenyi mpohorenyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it)
I would leave the rotation animation on the delete button, and just a small zoom on the other buttons

@OlhaKoziuk OlhaKoziuk merged commit c9aea4e into master Dec 19, 2023
1 check passed
@mpohorenyi mpohorenyi deleted the add-empty-section branch December 27, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpohorenyi mpohorenyi mpohorenyi approved these changes

@dsfreedom dsfreedom dsfreedom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlhaKoziuk @dsfreedom @mpohorenyi