Variants \ actions block #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlhaKoziuk
reviewed
Dec 20, 2023
| @@ -31,26 +29,51 @@ function getDetails( | |||
| if (color && capacity) { | |||
| return productDetail.additional.find( | |||
| (product) => product.color === color && product.capacity === capacity, | |||
| ); | |||
| ) || null; | |||
| } | |||
There was a problem hiding this comment.
not clear to me why null? We enter in this block when we definatly sure that we have such params. Or we can possibly receive underfind?
There was a problem hiding this comment.
The find method can return undefined, so to better typify this whole thing, I add null
OlhaKoziuk
reviewed
Dec 20, 2023
| } | ||
| } | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.