Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hexagon-based icons #567

Merged
merged 4 commits into from
Mar 30, 2019
Merged

Update hexagon-based icons #567

merged 4 commits into from
Mar 30, 2019

Conversation

colebemis
Copy link
Member

@colebemis colebemis commented Mar 30, 2019

I updated all the hexagon-based icons to use "perfect" hexagons.

Adds:

Updates:

  • box icon
  • package icon

@colebemis colebemis changed the title feat: Add hexagon icon Update hexagon-based icons Mar 30, 2019
@codecov
Copy link

codecov bot commented Mar 30, 2019

Codecov Report

Merging #567 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #567   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f27d8b0...0e57a46. Read the comment docs.

@colebemis colebemis merged commit 8f65819 into master Mar 30, 2019
@csandman
Copy link
Contributor

csandman commented Apr 1, 2019

@colebemis Not sure if you were aware but some of the strokes for the codesandbox icon are sticking out of the sides. Its not super noticeable but when you make the icon larger it catches the eye.

Screenshot 2019-03-31 20 20 07

Just messed around with it a little bit, this can be fixed by setting the caps on the lines that are overlapping to none!

EDIT

I see now why my solution would not work, the build process applies the linecaps to the svg itself and it is not set on the individual strokes themselves. I am not sure how you should fix this but it is still something that should be addressed.

@colebemis colebemis deleted the update-hexagons branch November 17, 2019 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Request: Codesandbox Icon Request: Node.js
2 participants