Retry test failures on Unity #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to scheduled trigger only when merging.)
cynthiajoan
reviewed
May 15, 2024
| @@ -0,0 +1,128 @@ | |||
| # Copyright 2023 Google LLC | |||
There was a problem hiding this comment.
Eh, this is mostly a copy of the script from C++ that was written in 2023, should it still be 2024?
cynthiajoan
approved these changes
May 15, 2024
github-actions
bot
added
the
tests: in-progress
✅ Integration test succeeded!Requested by @firebase-workflow-trigger[bot] on commit f677984 |
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It will retry all build errors that match timeout/network error regexes, but not any compiler errors or other issues. (If there are other instances in which the builds sometimes fail transiently, we can add that.)
Not sure under what conditions to actually trigger the test retry, so it does it unconditionally.
Testing
Tested manually with the "scheduled_trigger" check in integration_tests.yaml commented out, and failure forced.
This run: https://github.com/firebase/firebase-unity-sdk/actions/runs/9087398748
Type of Change
Place an
xthe applicable box: