Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workaround for invalid test logs #1032

Merged
merged 1 commit into from
May 21, 2024
Merged

Add a workaround for invalid test logs #1032

merged 1 commit into from
May 21, 2024

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

Sometimes the Unity editor test logs have an invalid character for utf-8, which causes errors. Add some error handling, replacing any bad characters discovered.


Testing

Describe how you've tested these changes.

https://github.com/firebase/firebase-unity-sdk/actions/runs/9182014476


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested a review from jonsimantov May 21, 2024 22:43
@a-maurice a-maurice merged commit 0e990e6 into main May 21, 2024
10 checks passed
@a-maurice a-maurice deleted the am-testapp_encoding branch May 21, 2024 23:08
@firebase firebase locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants