Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logic around removeAll tag and newer gradle versions #955

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

Improve the logic to only add the property removeAll tag if the gradle version being used is old enough that it doesn't support the property tag in the manifest merger. By default this should apply to Unity 2022+.


Testing

Describe how you've tested these changes.

Testing this locally across both older and newer Unity versions.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

#945

@a-maurice a-maurice changed the title Am gradle check Improve logic around removeAll tag and newer gradle versions Feb 28, 2024
@a-maurice a-maurice merged commit 42600cf into main Feb 29, 2024
4 checks passed
@a-maurice a-maurice deleted the am-gradle_check branch February 29, 2024 18:54
@firebase firebase locked and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants