Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RemoteConfig ConfigInfo swig generation #961

Merged
merged 3 commits into from
May 8, 2024
Merged

Refactor RemoteConfig ConfigInfo swig generation #961

merged 3 commits into from
May 8, 2024

Conversation

a-maurice
Copy link
Collaborator

@a-maurice a-maurice commented Mar 6, 2024 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Refactor Remote Config's ConfigInfo class to be handwritten instead of using SWIG to generate the class.

Testing

Describe how you've tested these changes.

https://github.com/firebase/firebase-unity-sdk/actions/runs/8165714354

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested a review from jonsimantov April 3, 2024 20:44
@a-maurice a-maurice merged commit d1d97e4 into main May 8, 2024
4 checks passed
@a-maurice a-maurice deleted the am-rc_configinfo branch May 8, 2024 19:21
@firebase firebase locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-maurice @jonsimantov