Merge pull request #54 from fixstars/feature/avoid-unload-dso

Do not unload the DSO
fixstars · Feb 10, 2021 · 52c2f04 · 52c2f04
2 parents 24194c6 + facb09d
commit 52c2f04
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/dynamic_module.h b/src/dynamic_module.h
@@ -42,10 +42,12 @@ class DynamicModule {
 
      ~DynamicModule() {
          if (handle_ != nullptr) {
+             // NOTE: DSO which is loaded by with_bb_module should not be unloaded even if Builder is destructed.
+             // Loading more than twice does not have any side effects.
 #ifdef _WIN32
-             FreeLibrary(handle_);
+//             FreeLibrary(handle_);
 #else
-             dlclose(handle_);
+//             dlclose(handle_);
 #endif
          }
      }