Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search with paging extensions. #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

INEL-IT
Copy link
Contributor

@INEL-IT INEL-IT commented Nov 24, 2022

Add search with paging extensions to simplify large searches.

results.AddRange(response.Entries);

PageResultResponseControl pageResultResponseControl;
while (true)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check cancellationToken instead of true

while(!token.IsCancellationRequested)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would result in returning an incomplete result if the token was cancelled before all requests were processed, instead of throwing an exception, which is not a desired behaviour.
With the cancellation token fix PR that was already accepted the SendRequestAsync call will throw an exception if the token was cancelled which is what we would want to happen.

Copy link
Owner

@flamencist flamencist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix comments

@INEL-IT
Copy link
Contributor Author

INEL-IT commented Nov 28, 2022

Please check the reply in the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants