Optimize RootDse search and add cancellation tokens to async search extensions. #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lation tokens to async search extensions.
flamencist
requested changes
Nov 27, 2022
LdapForNet/LdapSearchExtensions.cs
Outdated
| return (await connection.SearchAsync( | ||
| null, | ||
| "(objectclass=*)", | ||
| new[] { "*", "+", "supportedExtension" }, |
There was a problem hiding this comment.
it doesn't work on unix subsystems. Need to specify all properties
new[]
{
"namingContexts", "subschemaSubentry", "supportedLDAPVersion", "supportedSASLMechanisms",
"supportedExtension", "supportedControl", "supportedFeatures", "vendorName", "vendorVersion"
}
```
… common attributes for popular vendors.
|
Changed so both the wildcard selectors for user and operation attributes as well as an explicit list of most common attributes (both per RFC as well as common vendors like MS, OpenLdap, etc.) is passed to a single search. This seems to work in all situations as per RFC any duplicated attributes should be ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get RootDse entry with all attributes in a single request as per LDAP RFC standard and add cancellation tokens to async search extensions.