chore: use a more generic name for max limit

flanksource · Aug 26, 2024 · dafdb24 · dafdb24
1 parent 2e83d6b
commit dafdb24
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/internal/fs/s3.go b/internal/fs/s3.go
@@ -16,6 +16,7 @@ import (
 	"github.com/flanksource/commons/utils"
 	"github.com/flanksource/duty/connection"
 	"github.com/flanksource/duty/context"
+	"github.com/samber/lo"
 )
 
 // s3FS implements
@@ -51,8 +52,8 @@ func NewS3FS(ctx context.Context, bucket string, conn connection.S3Connection) (
 	return client, nil
 }
 
-func (t *s3FS) SetMaxList(maxList int32) {
-	t.maxList = &maxList
+func (t *s3FS) SetPageSize(maxList int) {
+	t.maxList = lo.ToPtr(int32(maxList))
 }
 
 func (t *s3FS) Close() error {

diff --git a/internal/fs/s3_test.go b/internal/fs/s3_test.go
@@ -50,7 +50,7 @@ func TestS3Glob(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	fs.SetMaxList(2) // Test pagination
+	fs.SetPageSize(2) // Test pagination
 
 	// json/
 	// └── flanksource/