Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add External Data Checker Functionality #58

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RayJW
Copy link
Contributor

@RayJW RayJW commented Nov 21, 2024

This adds External Data Checker functionality to help with creating new releases. This should make the process a lot easier, since new releases will automatically trigger a PR, which can simply be merged.

@flathubbot
Copy link

Started test build 163790

@flathubbot
Copy link

Build 163790 failed

@RayJW
Copy link
Contributor Author

RayJW commented Nov 21, 2024

Okay, I see the problem. So this probably not possible to fully automate since the generated-sources.json can't be pulled from upstream like this because of the order the steps are executed. This could be resolved by adding a workflow to the repo that updates this file from upstream when a new version is released, like others have done. Although, the workflow could be simpler as it only has to pull the upstream file. The other option would be to just leave it like this and manually update the file for every PR. The workload would still be reduced as the bot does everything except that step, which means the build would always fail until a maintainer does that by hand for every PR from Flathub Bot (reference).

The other option would be building the package upstream and then simply packaging the binary here, as that would be way less of a hassle. But I understand that this would be the less desirable solution.

@flathubbot
Copy link

Started test build 163822

@flathubbot
Copy link

Build 163822 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/146906/com.notesnook.Notesnook.flatpakref

@flathubbot
Copy link

Started test build 165761

@flathubbot
Copy link

Build 165761 failed

@RayJW
Copy link
Contributor Author

RayJW commented Dec 2, 2024

This won't build properly until the Flatpak uses a tagged commit again. I guess merging can wait until a new release is out, if the devs are interested in this PR at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants