Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use subdirectory of Freedesktop user directories for recordings #341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use subdirectory of Freedesktop user directories for recordings #341

wants to merge 1 commit into from

Conversation

camelCaseNick
Copy link

@camelCaseNick camelCaseNick commented Jul 11, 2022 •
edited
Loading

fixes #259, supersedes #262

To comply with custom and localized user document directories, this modification of the wrapper creates a symbolic link to the hard-coded Documents and hence bypasses (i.e. hacks around) this limitation of Zoom. (especially useful with #257 unfixed)

To do that, Zoom additionally needs file system read-only access to the user directory config at xdg-config/user-dirs.dirs.

see also:

@flathubbot
Copy link
Contributor

Started test build 100368

@flathubbot
Copy link
Contributor

Build 100368 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/98100/us.zoom.Zoom.flatpakref

@camelCaseNick camelCaseNick changed the title use subdirectory of Freedesktop user directories for Zoom's use subdirectory of Freedesktop user directories for recordings Jul 11, 2022
@flathubbot
Copy link
Contributor

Started test build 100532

@flathubbot
Copy link
Contributor

Build 100532 failed

@camelCaseNick
Copy link
Author

bot, build us.zoom.Zoom

@flathubbot
Copy link
Contributor

Queued test build for us.zoom.Zoom.

@flathubbot
Copy link
Contributor

Started test build 100535

@flathubbot
Copy link
Contributor

Build 100535 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/98268/us.zoom.Zoom.flatpakref

@flathubbot
Copy link
Contributor

Started test build 18973

@flathubbot
Copy link
Contributor

Build 18973 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/1598/us.zoom.Zoom.flatpakref

@flathubbot
Copy link
Contributor

Started test build 20195

@flathubbot
Copy link
Contributor

Build 20195 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/2827/us.zoom.Zoom.flatpakref

@flathubbot
Copy link
Contributor

Started test build 20200

@flathubbot
Copy link
Contributor

Build 20200 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/2831/us.zoom.Zoom.flatpakref

@flathubbot
Copy link
Contributor

Started test build 24433

@flathubbot
Copy link
Contributor

Build 24433 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/7079/us.zoom.Zoom.flatpakref

@flathubbot
Copy link
Contributor

Started test build 25669

@flathubbot
Copy link
Contributor

Build 25669 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/8328/us.zoom.Zoom.flatpakref

@violetmage
Copy link

violetmage commented Mar 2, 2023 •
edited
Loading

I had a wierd idea:

What if we set the permissions to only --filesystem=xdg-videos (or just xdg-documents), and just always symlinked ~/Documents/Zoom to $XDG_VIDEOS from within the flatpak. That way, we wouldn't need access to xdg-users-dirs. This might also apply to downloads in zoom, not sure atm.

Might try this tomorrow or something, unless someone has a better idea.

Also, if this works, we can close #146 and #262

@flathubbot
Copy link
Contributor

Started test build 29556

@flathubbot
Copy link
Contributor

Build 29556 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/12220/us.zoom.Zoom.flatpakref

@camelCaseNick
Copy link
Author

@violetmage If you wanted that, I wouldn't use directly the root xdg video directory, but still a Zoom subdirectory for that.

First, I thought that could be an interesting idea, but there are reasons not to:

  1. There is no $XDG_VIDEO. Videos is also localised the same way Documents is, so no benefit in that regard.
  2. Also, Zoom doesn't only store videos in its subdirectory, that might be confusing.
  3. Thirdly, this hack here arguably at least keeps the spirit of Zoom's folder structure. I wouldn't want to break it too much, to not fragment the spectrum of different Zoom installations.

@flathubbot
Copy link
Contributor

Started test build 54063

@flathubbot
Copy link
Contributor

Build 54063 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/36704/us.zoom.Zoom.flatpakref

@flathubbot
Copy link
Contributor

Started test build 58862

@flathubbot
Copy link
Contributor

Build 58862 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/41497/us.zoom.Zoom.flatpakref

@flathubbot
Copy link
Contributor

Started test build 79254

@flathubbot
Copy link
Contributor

Build 79254 failed

@flathubbot
Copy link
Contributor

Started test build 91081

@flathubbot
Copy link
Contributor

Build 91081 failed

@flathubbot
Copy link
Contributor

Started test build 91083

@flathubbot
Copy link
Contributor

Build 91083 failed

@flathubbot
Copy link
Contributor

Started test build 91084

@flathubbot
Copy link
Contributor

Build 91084 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/73764/us.zoom.Zoom.flatpakref

@flathubbot
Copy link
Contributor

Started test build 91771

@flathubbot
Copy link
Contributor

Build 91771 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/74460/us.zoom.Zoom.flatpakref

@flathubbot
Copy link
Contributor

Started test build 93083

@flathubbot
Copy link
Contributor

Build 93083 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/75764/us.zoom.Zoom.flatpakref

@flathubbot
Copy link
Contributor

Started test build 98214

@flathubbot
Copy link
Contributor

Build 98214 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/80993/us.zoom.Zoom.flatpakref

@camelCaseNick
let Zoom use xdg user dirs
0888dd3 
To comply with custom and localized user document
directories, this modification of the wrapper creates a
symbolic link to the hard-coded Documents and hence
bypasses (i.e. hacks around) the limitation of Zoom, of
hardcoding the English default value for the
Freedesktop.org user directory for documents.

See https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html
See https://freedesktop.org/wiki/Software/xdg-user-dirs/
Fixes flathub#259

Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
@flathubbot
Copy link
Contributor

Started test build 105698

@flathubbot
Copy link
Contributor

Build 105698 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/88504/us.zoom.Zoom.flatpakref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not respect XDG_DOCUMENTS_DIR variable
3 participants
@camelCaseNick @flathubbot @violetmage