Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gitops with dogfood. #17098

Merged
merged 11 commits into from
Feb 28, 2024
Merged

Use gitops with dogfood. #17098

merged 11 commits into from
Feb 28, 2024

Conversation

getvictor
Copy link
Member

@getvictor getvictor commented Feb 22, 2024

#17043

Set up dogfood to use gitops. I copied the current dogfood configs/policies/queries into the gitops flow.

Successful workflow run: https://github.com/fleetdm/fleet/actions/runs/8023101797/job/21918883543?pr=17098

Copy link
Member

@noahtalerman noahtalerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good!

Left a comment about some lingering TODOs that can probably be addressed in a separate PR.

Also sanity checking w/ that merging in this PR won't break https://fleetdm.com/try-fleet/explore-data in a comment here: #17007 (comment)

enable_disk_encryption: true
macos_settings:
custom_settings:
- path: ../../mdm_profiles/automatic_updates.mobileconfig
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see we're referencing the mdm_profiles/

I think we want to move this under the lib/ folder so we're following the best practice. Maybe we do that in a separate PR after this gets merged?

Also, heads up that there's some GitHub workflows cleanup that we want to do as well (from the user story):

Screenshot 2024-02-27 at 5 24 50 PM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's move mdm_profiles in another PR. I deleted the old workflows.

@noahtalerman
Copy link
Member

@getvictor heads up, I made these changes:

  • Removed the Windows lock/unlock scripts because we shipped the lock/unlock UI/API.
  • Removed common.policies.yml and created macos-device-health.policies.yml, windows-device-health.policies.yml, and linux-device-health.policies.yml
    • I think we want this to be the best practice (we have it this was in GitOps repo)
  • I removed common.queries.yml and added individual files for queries
    • I think we want this to be the best practice (we have it this was in GitOps repo)
  • Updated the teams accordingly

@getvictor
Copy link
Member Author

I tested the configs locally. Merging to main.

@getvictor getvictor merged commit f36b7d4 into main Feb 28, 2024
3 checks passed
@getvictor getvictor deleted the victor/17043-dogfood-gitops branch February 28, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants