-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gitops with dogfood. #17098
Use gitops with dogfood. #17098
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are looking good!
Left a comment about some lingering TODOs that can probably be addressed in a separate PR.
Also sanity checking w/ that merging in this PR won't break https://fleetdm.com/try-fleet/explore-data in a comment here: #17007 (comment)
enable_disk_encryption: true | ||
macos_settings: | ||
custom_settings: | ||
- path: ../../mdm_profiles/automatic_updates.mobileconfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see we're referencing the mdm_profiles/
I think we want to move this under the lib/
folder so we're following the best practice. Maybe we do that in a separate PR after this gets merged?
Also, heads up that there's some GitHub workflows cleanup that we want to do as well (from the user story):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's move mdm_profiles
in another PR. I deleted the old workflows.
@getvictor heads up, I made these changes:
|
I tested the configs locally. Merging to main. |
#17043
Set up dogfood to use gitops. I copied the current dogfood configs/policies/queries into the gitops flow.
Successful workflow run: https://github.com/fleetdm/fleet/actions/runs/8023101797/job/21918883543?pr=17098