Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for adding cancel functionality to the host details activity #25329

Draft
wants to merge 16 commits into
base: feat-upcoming-activites-queue
Choose a base branch
from

Conversation

ghernandez345
Copy link
Contributor

For #23912

Add the ability to cancel upcoming activities in the UI. This adds that functionality but also changes the design of the activities used on the past and upcoming feeds. This PR includes:

**new UI for activities on past and upcoming activity feeds **

image

ability to cancel an upcoming activity

image

NOTE: there will need to be more work done to integrate with the API when this is ready. That will be done in another PR. There will also be another PR for moving this new activity design to the global activities feed.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • Added/updated automated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 63.84%. Comparing base (e956220) to head (6551545).
Report is 1 commits behind head on feat-upcoming-activites-queue.

Files with missing lines Patch % Lines
frontend/services/entities/activities.ts 0.00% 3 Missing ⚠️
frontend/utilities/endpoints.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           feat-upcoming-activites-queue   #25329      +/-   ##
=================================================================
- Coverage                          63.85%   63.84%   -0.01%     
=================================================================
  Files                               1616     1616              
  Lines                             153833   153839       +6     
  Branches                            3975     3976       +1     
=================================================================
+ Hits                               98224    98225       +1     
- Misses                             47796    47801       +5     
  Partials                            7813     7813              
Flag Coverage Δ
frontend 53.21% <44.44%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant