-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI for adding cancel functionality to the host details activity #25329
Draft
ghernandez345
wants to merge
16
commits into
feat-upcoming-activites-queue
Choose a base branch
from
feat-ui-upcoming-activities-queue
base: feat-upcoming-activites-queue
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
UI for adding cancel functionality to the host details activity #25329
ghernandez345
wants to merge
16
commits into
feat-upcoming-activites-queue
from
feat-ui-upcoming-activities-queue
+411
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghernandez345
had a problem deploying
to
Docker Hub
January 10, 2025 14:52 — with
GitHub Actions
Error
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat-upcoming-activites-queue #25329 +/- ##
=================================================================
- Coverage 63.85% 63.84% -0.01%
=================================================================
Files 1616 1616
Lines 153833 153839 +6
Branches 3975 3976 +1
=================================================================
+ Hits 98224 98225 +1
- Misses 47796 47801 +5
Partials 7813 7813
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ghernandez345
temporarily deployed
to
Docker Hub
January 10, 2025 15:04 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #23912
Add the ability to cancel upcoming activities in the UI. This adds that functionality but also changes the design of the activities used on the past and upcoming feeds. This PR includes:
**new UI for activities on past and upcoming activity feeds **
ability to cancel an upcoming activity
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.