Housekeeping #73
Open
Housekeeping #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k depreciation warning
Warning: <Field render> has been deprecated and will be removed in future versions of Formik. Please use a child callback function instead. To get rid of this warning, replace <Field name="bookingForm.verifyHaveNamesContainer.verifyHaveNames" render={({field, form}) => ...} /> with <Field name="bookingForm.verifyHaveNamesContainer.verifyHaveNames">{({field, form, meta}) => ...}</Field>
Warning: A future version of React will block javascript: URLs as a security precaution. Use event handlers instead if you can. If you need to generate unsafe HTML try using dangerouslySetInnerHTML instead. React was passed "javascript:void(null)".
in a (created by Tabs)
in div (created by Tabs)
in nav (created by Tabs)
in div (created by Tabs)
in div (created by Tabs)
in div (created by Tabs)
in div (created by Tabs)
in Tabs (created by ElementRenderer)
in ElementRenderer (created by Context.Consumer)
in Unknown (created by Element)
in Element
in Element (created by Context.Consumer)
in FormikConnect(Object) (created by Form)
in form (created by Form)
in Form (created by ElementRenderer)
in ElementRenderer (created by Context.Consumer)
in Unknown (created by Element)
in Element
in Element (created by Context.Consumer)
in FormikConnect(Object) (created by FormikForm)
in FormikForm (created by Formik)
in Formik (created by ForwardRef)
in SchemaProvider (created by ForwardRef)
in ForwardRef (created by ExampleFormContainer)
in div (created by ExampleFormContainer)
in ExampleFormContainer (created by Demo)
in div (created by Demo)
in div (created by Demo)
in div (created by Demo)
in Demo
… Updated to jsonplaceholder and added cors headers
easeq
requested changes
Feb 28, 2020
There was a problem hiding this comment.
Please make the following changes:
- Add all babel related packages to devDependencies.
- Why have you added jQuery and popper.js? Is it because of bootstrap? Although the HTML used is in bootstrap style, there is no dependency on bootstrap, except for running the examples. So if jQuery and popper are necessary, add them to devDependecies.
- Please change the following to a single line format:
In src/Field/Autocomplete.js at line 51-53
From:
const {
name,
} = config;To:
const { name } = config;Everything else looks good. Thanks!
|
When will this be released? I'm concerned about the deprecated render method that is in place, and see that @tgrrr has addressed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great idea for a package, so I've just done some chores