This repository has been archived by the owner on Feb 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update compile to implementation #350
Open
multicastbr
wants to merge
100
commits into
dev
Choose a base branch
from
master
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow developers to do `MaterialViewPagerAnimator.ENABLE_LOG = false;` in their Application or Activity if they do not want the log spam.
allow app developers to enable/disable logging
Based off the name of the function, it seems that `fromColorResAndDrawable` should take in a `Drawable` object, not a `String` imageUrl.
add the possibility to completly disable the viewpager-toolbar
Fix what seems to be a mistake in fromColorResAndDrawable
mHeader color flickering while swiping tabs #117 fixed
Fixed blinking header on a quick swipe
Check if yOffset is negative.
Fix broken headings in Markdown files
One line 431, it says `mRecyclerView.addDecoration(new MaterialViewPagerHeaderDecorator());` which is the incorrect syntax. It should be `addItemDecoration` as the other one does not exist.
Incorrect Syntax in README.md
Upgrade glide dependency to 4.0.0
` java.lang.IllegalStateException: You can't start or clear loads in RequestListener or Target callbacks. If you must do so, consider posting your into() or clear() calls to the main thread using a Handler instead.` is thrown on Glide 4.2.0 onwards. To fix this issue see bumptech/glide#2473
Fix java.lang.IllegalStateException
Fix link to tutos-android-france.com
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the deprecated compile to the new implementation