go: Initial commit #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcarley
commented
Oct 16, 2024
go/.flox/env/manifest.toml
Outdated
Comment on lines
17
to
21
| [hook] | ||
| on-activate = ''' | ||
| # Point GOENV to Flox environment cache | ||
| export GOENV="$FLOX_ENV_CACHE/goenv" | ||
| ''' |
There was a problem hiding this comment.
From @stealthybox:
also not sure if we should be using the Flox env project cache -- usually Go is pretty good about the global cache for deps/builds/source, but maybe a more pure build could benefit
I'm also not sure about this. Would have to look up the history and confidence-level that we originally added it to the setup hook. We could omit it for now if we're unsure.
dcarley
commented
Oct 16, 2024
There was a problem hiding this comment.
Might be a good idea to include glibc for Linux too so that we don't compile CGO against system libs.
There was a problem hiding this comment.
Let's punt on this for the moment. We can revisit later.
Common packages for working on Go projects. I frequently use this from my editor with: - https://github.com/flox/flox-direnv And the following in `.envrc`: use flox --remote floxenvs/go In future the editor dependencies could be broken out to a separate `go-editor` or `go-lsp` environment. The `GOENV` hook is copied from our `init --auto-setup` hook with the exception of: 1. Path is modified from `goenv` to `go` to match the other example environments in this repo 2. `go get .` is omitted because it's surprising to fetch dependencies when activating an environment and we have plans to remove it from the default manifest. The example module which includes a third-party module to prove that dependency fetching still works is taken from: - https://go.dev/blog/using-go-modules The minimum Go version is currently pinned, both in the `manifest.toml` and `go.mod`, at the latest stable major and minor version. It should continue to work after a `flox upgrade` assuming that there are no breaking changes.
|
@garbas I've rebased in the changes that we paired on. |
garbas
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common packages for working on Go projects.
I frequently use this from my editor with:
And the following in
.envrc:In future the editor dependencies could be broken out to a separate
go-editororgo-lspenvironment.The
GOENVhook is copied from ourinit --auto-setuphook with theexception of:
goenvtogoto match the other exampleenvironments in this repo
go get .is omitted because it's surprising to fetch dependencieswhen activating an environment and we have plans to remove it from
the default manifest.
The example module which includes a third-party module to prove that
dependency fetching still works is taken from:
The minimum Go version is currently pinned, both in the
manifest.tomland
go.mod, at the latest stable major and minor version. It shouldcontinue to work after a
flox upgradeassuming that there are nobreaking changes.