Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Application Menu Item: IsSplited="True" Gray line issue #121

Closed
wants to merge 3 commits into from
Closed

Conversation

vdrasutis
Copy link
Contributor

Fixing this issue MenuItem: IsSplited="True" gray line issue #115

vdrasutis added 3 commits May 25, 2015 23:20
Fixing this issue MenuItem: IsSplited="True" gray line issue #115 (

#115 (comment)
)
#120 : Improved ApplicationMenuItemTemplate, added:
ToolTip support - useful for Recent Files in example To show file
paths....
Description support (align to Right) - useful for showing short-cut keys
and so on.
…d button and Show QAT Above/Below Ribbon.

Fixed  ContextMenu issue mentioned in #122 for Colapse/Expand button and

Show Quick  Access Tool Bar Above/Below  Ribbon (MenuItem
CanAddToQuickAccessToolBar="False" is still NOT fixed).
@batzen
Copy link
Member

batzen commented May 29, 2015

This does not compile.

You are fixing multiple issues in this PR. It would be nice if you could create separate PRs for each issue you are fixing, this makes reviewing and verifying easier for me.

The change for showing Description on the menu items does not look good to me. You should fix that by changing the code to be consistent with other parts in the application menu showing a description. I don't think it's a good idea to place TextBlock in TextBlock. Not inlining textblock into textblock should also resolve your issue of forcing a set width for the menuitem.

@vdrasutis
Copy link
Contributor Author

Hi. Do not know (until now) how this works and how to create separate PR - I see that for every change I need to create new branch... Maybe you can by your self fix cheese bugs - It will be faster and better than reviewing my crappy code, because you know how everything works :).

@batzen
Copy link
Member

batzen commented May 29, 2015

I can, but that will take probably two weeks as i am very busy right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants