Changes to support mmap reads on Broker #57
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariharan-devarajan
force-pushed
the
feature/mmap_io
branch
from
bef45cc to
a776a0a
Compare
JaeseungYeom
reviewed
Dec 3, 2023
src/utils/read_all.c
Outdated
Comment on lines
24
to
29
| void * allocate_aligned(size_t size) { | ||
| size_t alignment = getpagesize(); | ||
| int malloc_offset = (size + alignment) % alignment; | ||
| void* mem = malloc(size + alignment); | ||
| return (char*) mem + malloc_offset; | ||
| } |
There was a problem hiding this comment.
I do not think that this will guarantee that the address is a multiple of alignment, while the size of the usable block is. In addition, i am wondering if it would be safe to use such an address with munmap().
We can instead rely on posix_memalign()
JaeseungYeom
reviewed
Dec 3, 2023
| @@ -37,8 +46,13 @@ ssize_t write_all (int fd, const void *buf, size_t len) | |||
| return count; | |||
| } | |||
|
|
|||
| ssize_t read_all (int fd, void **bufp) | |||
| ssize_t read_all (const char* filename, void **bufp) | |||
There was a problem hiding this comment.
This interface probably should take a page aligned memory address as an input for the UCX managed memory. So, the allocation would happen outside of this function.
There was a problem hiding this comment.
That is the buffer bufp. Once we do the UCX, we can move allocation there.
hariharan-devarajan
force-pushed
the
feature/mmap_io
branch
from
cc2f91e to
3e9a46c
Compare
|
@JaeseungYeom do u want me to work on this? |
|
Need to check the following before continuing:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to support mmaped reads on broker.